Add missing style on file details object permissions #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lucas ONeil <[email protected]>
loneil
requested review from
jujaga,
kamorel,
TimCsaky and
bcgv123
as code owners
loneil
changed the title
jujaga
approved these changes
Mar 10, 2023
Coverage Report (Application)
|
Coverage Report (Frontend)
|
TimCsaky
approved these changes
Mar 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Missed setting the style on the File Details > Object Permissions dialog
We really should refactor this to a ObjectPermissionsButton component since it's used in 2 places, we don't need to be doing "hey here's the button, clicking the button does this, here's the dialog, the dialog contains this component" twice. But leaving that for the immediate term since I see tickets in progress about file permissions, and the file details page, so let's avoid possible merge conflict right now.
Types of changes
Checklist
Further comments