Store refactor #43
Merged
Store refactor #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage Report (Application)
|
jujaga
reviewed
Mar 2, 2023
TimCsaky
reviewed
Mar 3, 2023
This change ensures that we are properly leveraging nested router definitions correctly and that it shows up on the vue tools inspector as intended. It also does a first crack at ensuring that only route points that require query parameter handling leverage the createProps helper. Lastly, a duplicate route definition is removed. Signed-off-by: Jeremy Ho <[email protected]>
kamorel
force-pushed
the
feature/store-refactor
branch
from
7125a5f to
89ae5d7
Compare
In general, lower level layers should not have dependencies to higher layers. This change was done in order to decouple and ensure these services can stand by themselves. We also take this opportunity to improve the type declarations used. Signed-off-by: Jeremy Ho <[email protected]>
In general, an authenticated user will need to know the database userId in order to perform subsequent business logic. Instead of depending on a separate userstore to cache this information, we instead let the authentication system handle this for us as the userId's lifecycle is the same as the logged-in user's session. We also tack on a few more copy buttons to the developer view. Signed-off-by: Jeremy Ho <[email protected]>
This commit adds general support for pinia store data to be written into localstorage. This will eventually give us the benefit of caching data across page restarts and across tab sessions, which ideally will help us reduce the number of network calls dispatched to COMS. Signed-off-by: Jeremy Ho <[email protected]>
The services must be instantiated within the function; otherwise the app cannot import correctly and boot up. Signed-off-by: Jeremy Ho <[email protected]>
Signed-off-by: Jeremy Ho <[email protected]>
kamorel
force-pushed
the
feature/store-refactor
branch
from
36fdfac to
8e5e079
Compare
Coverage Report (Frontend)
|
jujaga
approved these changes
Mar 7, 2023
bcgv123
approved these changes
Mar 7, 2023
TimCsaky
approved these changes
Mar 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Types of changes
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Checklist
Further comments