Implementation of 2966 bucket configure #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage Report (Application)
|
bcgv123
force-pushed
the
feat/2966-bucket-configure
branch
from
0a0eca8 to
c8860b7
Compare
Coverage Report (Frontend)
|
|
Discussed REDACTED field password write issue in Discord. |
|
Could also consider validating bucket url to ensure it's URL
|
TimCsaky
reviewed
Feb 14, 2023
kamorel
reviewed
Feb 14, 2023
kamorel
reviewed
Feb 14, 2023
kamorel
reviewed
Feb 14, 2023
Valid, but i'd prefer to have the FE yup validation schema match that of COMS which it is currently doing. |
kamorel
reviewed
Feb 14, 2023
Comment on lines
41
to
54
| const formBucket = { | ||
| bucketName: values.bucketName, | ||
| bucket: values.bucket, | ||
| endpoint: values.endpoint, | ||
| accessKeyId: values.accessKeyId, | ||
| secretAccessKey: values.secretAccessKey, | ||
| key: values.key | ||
| } as Bucket; | ||
|
|
There was a problem hiding this comment.
Use object spread syntax.
const formBucket: Bucket = { ...values };
There was a problem hiding this comment.
Kyle, here lint forces me to define the rest of the object. For example: region cannot be empty (getting error from the back-end) and don't have this info initialy.
added 11 commits
February 15, 2023 11:49
…a new bucket and update. Form contains required bucket fields, submit and cancel.
…ng of TextInput to support validation.
…eys. Reordering imports and removing async.
bcgv123
force-pushed
the
feat/2966-bucket-configure
branch
from
852e3be to
8dad7f6
Compare
TimCsaky
reviewed
Feb 15, 2023
jujaga
reviewed
Feb 15, 2023
kamorel
reviewed
Feb 15, 2023
kamorel
reviewed
Feb 15, 2023
added 5 commits
February 15, 2023 14:15
kamorel
reviewed
Feb 16, 2023
kamorel
reviewed
Feb 16, 2023
kamorel
reviewed
Feb 16, 2023
kamorel
reviewed
Feb 16, 2023
TimCsaky
approved these changes
Feb 16, 2023
…ative path changed to an absolute, removed invalid attribute
kamorel
approved these changes
Feb 16, 2023
jujaga
approved these changes
Feb 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr contains implementation of Bucket Configure feature. It includes 'Configure New Bucket' dialog and form as a separate components. Fields on form are generated by common TextInput component. TextInput supports field validation (required at the moment). The submit of the form is not allowed unless all the fields are populated. Update Bucket Configure is happening on wheel icon click and brings up the same dialog, but it loads the updating bucket into the fields instead of being empty.
Types of changes
Checklist
Further comments