Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show correct bucket/object permissions after updating #33

Merged
merged 2 commits into from
Feb 10, 2023

Conversation

kamorel
Copy link
Contributor

@kamorel kamorel commented Feb 3, 2023

Description

Ensures proper permissions are shown in the bucket/object permissions table after either successfully updating or encountering an error.

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@github-actions
Copy link

github-actions bot commented Feb 3, 2023

Coverage Report (Frontend)

Totals Coverage
Statements: 43.68% ( 38 / 87 )
Methods: 25% ( 6 / 24 )
Lines: 53.85% ( 28 / 52 )
Branches: 36.36% ( 4 / 11 )

@github-actions
Copy link

github-actions bot commented Feb 3, 2023

Coverage Report (Application)

Totals Coverage
Statements: 75% ( 51 / 68 )
Methods: 62.5% ( 5 / 8 )
Lines: 82.61% ( 38 / 46 )
Branches: 57.14% ( 8 / 14 )

@kamorel kamorel force-pushed the feature/perm-rollback-on-error branch from 17e7903 to fb2524c Compare February 10, 2023 18:23
@jujaga jujaga added this pull request to the merge queue Feb 10, 2023
@jujaga jujaga removed this pull request from the merge queue due to a manual request Feb 10, 2023
@jujaga jujaga added this pull request to the merge queue Feb 10, 2023
Merged via the queue into master with commit 165a028 Feb 10, 2023
@jujaga jujaga deleted the feature/perm-rollback-on-error branch February 10, 2023 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants