Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IDP specific user search functionality #26

Merged
merged 7 commits into from
Jan 25, 2023
Merged

IDP specific user search functionality #26

merged 7 commits into from
Jan 25, 2023

Conversation

kamorel
Copy link
Contributor

@kamorel kamorel commented Jan 20, 2023

Description

  • Implements IDP specific search functionality dependent on the searchable flag
  • Refactors the user search into its own reuse component
  • Adds a new column to the bucket permission table to display the IDP of the user

Types of changes

New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@github-actions
Copy link

Coverage Report (Application)

Totals Coverage
Statements: 75% ( 51 / 68 )
Methods: 62.5% ( 5 / 8 )
Lines: 82.61% ( 38 / 46 )
Branches: 57.14% ( 8 / 14 )

@github-actions
Copy link

Coverage Report (Frontend)

Totals Coverage
Statements: 43.68% ( 38 / 87 )
Methods: 25% ( 6 / 24 )
Lines: 53.85% ( 28 / 52 )
Branches: 36.36% ( 4 / 11 )

TimCsaky
TimCsaky reviewed Jan 23, 2023
View reviewed changes
Copy link
Contributor

@TimCsaky TimCsaky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome work. to be honest, i havent reviewed this in the browser but i hope to soon

frontend/src/store/bucketStore.ts Outdated Show resolved Hide resolved
frontend/src/components/form/SearchUsers.vue Show resolved Hide resolved
frontend/src/components/form/SearchUsers.vue Show resolved Hide resolved
frontend/src/components/form/SearchUsers.vue Show resolved Hide resolved
jujaga
jujaga reviewed Jan 24, 2023
View reviewed changes
.gitignore Outdated Show resolved Hide resolved
frontend/src/components/bucket/BucketPermissionAddUser.vue Outdated Show resolved Hide resolved
@kamorel kamorel force-pushed the feature/no-elevated-user-search branch from c4d689d to 02d0166 Compare January 25, 2023 18:51
jujaga
jujaga reviewed Jan 25, 2023
View reviewed changes
.gitignore Show resolved Hide resolved
@kamorel kamorel force-pushed the feature/no-elevated-user-search branch from cd94e5b to 2f359f7 Compare January 25, 2023 22:25
@jujaga jujaga merged commit c083b41 into master Jan 25, 2023
@jujaga jujaga deleted the feature/no-elevated-user-search branch January 25, 2023 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcgv123 bcgv123 bcgv123 approved these changes

@TimCsaky TimCsaky TimCsaky approved these changes

@jujaga jujaga jujaga approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kamorel @jujaga @TimCsaky @bcgv123