Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Magic Link redirection support and InviteButton component #179

Merged
merged 10 commits into from
Mar 15, 2024
Merged

Implement Magic Link redirection support and InviteButton component #179

merged 10 commits into from
Mar 15, 2024

Conversation

jatindersingh93
Copy link
Contributor

@jatindersingh93 jatindersingh93 commented Mar 5, 2024 •
edited
Loading

Description

Types of changes

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 5, 2024

Coverage Report (Application)

Totals Coverage
Statements: 70.67% ( 53 / 75 )
Methods: 62.5% ( 5 / 8 )
Lines: 81.63% ( 40 / 49 )
Branches: 44.44% ( 8 / 18 )

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 5, 2024 •
edited
Loading

Coverage Report (Frontend)

Totals Coverage
Statements: 19.34% ( 695 / 3593 )
Methods: 18.46% ( 132 / 715 )
Lines: 23.26% ( 485 / 2085 )
Branches: 9.84% ( 78 / 793 )

@jatindersingh93 jatindersingh93 force-pushed the magic-links branch 3 times, most recently from 63f3ee6 to 9ffb1da Compare March 9, 2024 00:27
@jujaga jujaga mentioned this pull request Mar 11, 2024
Closed
4 tasks
jujaga
jujaga reviewed Mar 12, 2024
View reviewed changes
frontend/src/components/common/InviteButton.vue Outdated Show resolved Hide resolved
frontend/src/components/common/InviteButton.vue Outdated Show resolved Hide resolved
frontend/src/components/common/InviteButton.vue Show resolved Hide resolved
frontend/src/components/common/InviteButton.vue Outdated Show resolved Hide resolved
frontend/src/components/common/InviteButton.vue Show resolved Hide resolved
frontend/src/services/permissionService.ts Outdated Show resolved Hide resolved
frontend/src/types/InviteCreateOptions.ts Show resolved Hide resolved
frontend/src/views/invite/InviteView.vue Outdated Show resolved Hide resolved
@jujaga
Copy link
Member

jujaga commented Mar 12, 2024

Temporarily closing and reopening due to pipeline issues

@jujaga jujaga closed this Mar 12, 2024
@jujaga jujaga reopened this Mar 12, 2024
@jujaga jujaga changed the title add invitebutton component Implement Magic Link redirection support and add InviteButton component Mar 12, 2024
@jujaga jujaga changed the title Implement Magic Link redirection support and add InviteButton component Implement Magic Link redirection support and InviteButton component Mar 12, 2024
jujaga
jujaga reviewed Mar 13, 2024
View reviewed changes
frontend/src/services/inviteService.ts Outdated Show resolved Hide resolved
frontend/src/services/inviteService.ts Outdated Show resolved Hide resolved
frontend/src/views/invite/InviteView.vue Show resolved Hide resolved
@wilwong89 wilwong89 force-pushed the magic-links branch 3 times, most recently from 0f1c7e4 to ac82dbb Compare March 13, 2024 22:45
@jatindersingh93 jatindersingh93 marked this pull request as ready for review March 14, 2024 16:14
@kyle1morel kyle1morel merged commit 5194efb into master Mar 15, 2024
19 of 20 checks passed
@kyle1morel kyle1morel deleted the magic-links branch March 15, 2024 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wilwong89 wilwong89 wilwong89 left review comments

@kyle1morel kyle1morel kyle1morel approved these changes

@jujaga jujaga jujaga approved these changes

@TimCsaky TimCsaky Awaiting requested review from TimCsaky TimCsaky is a code owner

@norrisng-bc norrisng-bc Awaiting requested review from norrisng-bc norrisng-bc is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jatindersingh93 @jujaga @wilwong89 @kyle1morel