-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSS refactor to be more compatible with PrimeVue and improve layout on smaller screens #148
Conversation
New styling is imposing a bunch of white space on the right that looks off. Suggest matching the current Prod BCBox styling more closely when it comes to large browser resolutions. I'm at 2560 x 1440 using Chrome at 100% zoom. Although I did always think Prod BCBox was a bit -wide- so the main issue is that it is not centered - it would be more appropriate if the white space was distributed between left and right. So my advice is actually to slightly widen the content / reduce the margins, but also center the content. Line spacing appears to be more compact compared to the current Prod BCBox, suggest more space between rows of text to more closely match current Prod BCBox. I see the same margin/centering issue on the bucket list, but even more pronounced - the datatable is very narrow and this should be fixed. This margin/centering issue is also true for the object list. I have also noted that Upload/Download don't seem to have hover tooltips, but Delete does. I like the border width for buttons. Otherwise looks good to me! |
Thanks Tyler. this should be updated now: https://bcbox-dev-pr-148.apps.silver.devops.gov.bc.ca/ |
The very first image on the main page, under the Login to get started button has a bunch of padding in the image not present in live, or the other images on the pr. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if intentional, but the checkboxes (e.g. in the permissions modal) seem to be using the Primevue default light blue instead of the BC Gov dark blue (i.e. $bcbox-primary: #036
inside variables.scss
).
support ticket:
https://apps.nrs.gov.bc.ca/int/jira/browse/SHOWCASE-3384
consolidate our style sheets
resolve style conflicts
use primevue defaults where possible
make semi-responsive
Description
Types of changes
Checklist
Further comments