Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SC-3336, fix: update vite to 4.4.9, fix type reference in SearchUsers… #126

Merged
merged 1 commit into from
Sep 22, 2023

Conversation

wilwong89
Copy link
Contributor

Description

It turns out that importing a type reference incorrectly in SearchUsers.vue was causing an issue. An issue that didn't affect anything until updating Vite to 4.0.0 or above.

Updated vite to latest version 4.4.9 and fixed the issue.

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@github-actions
Copy link

Coverage Report (Application)

Totals Coverage
Statements: 75% ( 51 / 68 )
Methods: 62.5% ( 5 / 8 )
Lines: 82.61% ( 38 / 46 )
Branches: 57.14% ( 8 / 14 )

@github-actions
Copy link

Coverage Report (Frontend)

Totals Coverage
Statements: 36.22% ( 448 / 1237 )
Methods: 37.36% ( 102 / 273 )
Lines: 42.74% ( 309 / 723 )
Branches: 15.35% ( 37 / 241 )

@jujaga jujaga merged commit 8df17a5 into master Sep 22, 2023
@jujaga jujaga deleted the fix/SC3336-2 branch September 22, 2023 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants