Skip to content

Commit

Permalink
Merge pull request #70 from bcgov/bugfix/modals
Browse files Browse the repository at this point in the history
Bucket config modal updates
  • Loading branch information
jujaga authored Apr 13, 2023
2 parents e5b74c1 + 0549a4e commit 3f535cf
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 4 deletions.
2 changes: 1 addition & 1 deletion charts/bcbox/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name: bcbox
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 0.0.3
version: 0.0.4
kubeVersion: ">= 1.13.0"
description: A frontend UI for managing access control to S3 Objects
# A chart can be either an 'application' or a 'library' chart.
Expand Down
2 changes: 1 addition & 1 deletion charts/bcbox/templates/hpa.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{{- if .Values.autoscaling.enabled }}
---
apiVersion: autoscaling/v2beta2
apiVersion: autoscaling/v2
kind: HorizontalPodAutoscaler
metadata:
name: {{ include "bcbox.fullname" . }}
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/components/bucket/BucketConfigForm.vue
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,6 @@ const onSubmit = async (values: any) => {
}
);
} catch (error: any) {
emit('cancel-bucket-config');
toast.add(
{
severity: 'error',
Expand Down Expand Up @@ -145,6 +144,7 @@ const onCancel = () => {
label="Key"
placeholder="directory"
help-text="An optional path prefix within a bucket. The path will be created if it doesn't already exist."
:disabled="!!props.bucket"
/>
<Button
class="mt-2"
Expand Down
5 changes: 4 additions & 1 deletion frontend/src/components/form/TextInput.vue
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,15 @@ type Props = {
label?: string;
name: string;
placeholder?: string;
disabled?: boolean;
};
const props = withDefaults(defineProps<Props>(), {
helpText: '',
type: 'text',
label: '',
placeholder: ''
placeholder: '',
disabled: false
});
const { errorMessage, value } = useField<string>(toRef(props, 'name'));
Expand All @@ -31,6 +33,7 @@ const { errorMessage, value } = useField<string>(toRef(props, 'name'));
:name="name"
:placeholder="placeholder"
:class="{ 'p-invalid': errorMessage }"
:disabled="disabled"
/>
<small id="`${name}-help`">{{ helpText }}</small>
<ErrorMessage
Expand Down

0 comments on commit 3f535cf

Please sign in to comment.