Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migration for licensed works layer #398

Merged
merged 5 commits into from
Aug 18, 2020
Merged

Conversation

AlexZorkin
Copy link
Collaborator

No description provided.

@bc-iit-water bc-iit-water temporarily deployed to dev August 10, 2020 11:00 Inactive
@bc-iit-water bc-iit-water temporarily deployed to dev August 11, 2020 18:25 Inactive
Copy link
Contributor

@dainetrinidad dainetrinidad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked the PR link and I can see the new layer!

A few observations:

  • The switch case has gotten really big, we should think about moving that into a separate json file or something for easier maintenance in the future
  • The legend icon for Dike/Levee/Berm is not showing up (or it's just plain white -- is that intentional?)
  • Are there 5 layers within water_licensed_works?

@AlexZorkin
Copy link
Collaborator Author

Dike/Levee/Berm is a white line so that's why it's not showing. Asked Lindsay and she said leave it because it matches the databc version.
I had to add 5 layers for this layer to have dashed lines. Mapbox for whatever reason doesn't let you create multiple different styled lines within one layer. Really frustrating, the suggested solution was to create a unique layer for each style you need. It's been an outstanding issue for 3+ years: mapbox/mapbox-gl-js#3045

@AlexZorkin AlexZorkin merged commit 0c57bd4 into master Aug 18, 2020
@daine daine deleted the alex/waterlicencedworks branch April 19, 2021 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants