Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BCMOHAD-18955 || Fixing QA Deployment Errors #990

Merged
merged 3 commits into from
Nov 29, 2023
Merged

Conversation

NataliaNikishina
Copy link
Collaborator

@NataliaNikishina NataliaNikishina commented Nov 29, 2023

Removing hard coded reference in source code
Removing fields not applicable to the org
Ignoring inactive HIBC_Status path

The unknown user permission issue is related to the PR: 79c9b7f

It is related to manage package development permission which was recently pulled from Production. Jeff, I am assuming there is no concerns from your side if we remove it since it was empty in the repo by design.

Removing Packaging2PromoteVersion permission
Package development permission assignment needs to be perfromed as a post deployment step.

Copy link
Collaborator

@cgijeffolsen cgijeffolsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Collaborator

@Nikhiljeenru Nikhiljeenru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@NataliaNikishina NataliaNikishina merged commit 660adb7 into main Nov 29, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants