feat: add tools space access policy in system #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrwils
approved these changes
Sep 13, 2024
mbystedt
reviewed
Sep 13, 2024
There was a problem hiding this comment.
Would need to add policy to vault-approle.controller.ts for app.config.brokerGlobal. Simpler would be to add read for the tools access to the existing policy 'broker-auth'. But, I like this approach as well. Probably don't need to enable per-app brokers tokens to be able to read the tools of their apps.
| @@ -0,0 +1,14 @@ | |||
| # Write policy for tools space | |||
mbystedt
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add tools space access policy in system