[VampireTheMasquerade5th]判定ダイスが10個以上指定できないバグ修正 #644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #644 +/- ##
=======================================
Coverage 95.60% 95.60%
=======================================
Files 341 341
Lines 19560 19560
Branches 5094 5094
=======================================
Hits 18701 18701
Misses 859 859
☔ View full report in Codecov by Sentry. |
ysakasin
approved these changes
Sep 26, 2023
|
@FredGreenfield ありがとうございます！ マージしました。 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
【背景】
VMF、VMI両記法にて10個以上の判定ダイスが指定できないバグがあった。
難易度指定、Hungerダイスでは上記制限が無い事は確認済み。
ただし、Hungerダイスは現行ルールで5ダイス上限であるにも関わらず6ダイス以上指定できるためこれは別途対応を検討する。
【対応】
両記法ともに入力文字列を解釈する正規表現とテストケースを修正。