Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

天下繚乱のシステムを追加 #604

Merged
merged 3 commits into from
Mar 5, 2023

Conversation

h-mikisato
Copy link
Contributor

SRSベースのシステムなのでSRSを継承して作成

SRSベースのシステムなのでSRSを継承して作成
@codecov
Copy link

codecov bot commented Feb 28, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change

Comparison is base (dc0aa9a) 95.43% compared to head (989f094) 95.43%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #604   +/-   ##
=======================================
  Coverage   95.43%   95.43%           
=======================================
  Files         331      332    +1     
  Lines       18578    18589   +11     
  Branches     4825     4825           
=======================================
+ Hits        17730    17741   +11     
  Misses        848      848           
Impacted Files Coverage Δ
lib/bcdice/game_system.rb 100.00% <100.00%> (ø)
lib/bcdice/game_system/TenkaRyouran.rb 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@ysakasin ysakasin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#605 の方マージしたので、masterマージをして @, # 記法のテストケースも追加お願いします。

@ysakasin ysakasin merged commit 7b00d7e into bcdice:master Mar 5, 2023
@ysakasin
Copy link
Member

ysakasin commented Mar 5, 2023

ありがとうございます! マージしました。

@h-mikisato h-mikisato deleted the feature/add_tenka branch March 5, 2023 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants