Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ダイス面数の上限を 10,000 に増加 #544

Merged

Conversation

ViVi-shark
Copy link
Contributor

内容

ダイス面数の上限 BCDice::Randomizer::UPPER_LIMIT_DICE_SIDES を増加。

  • 変更前: 1,000
  • 変更後: 10,000

理由

1,000 より大きな面数のダイスロールをあつかうゲームに対応するため。

具体的な一例として、『オバケ空間探索配信RPG「実況ゴーストライヴ」』を想定しています。同ゲームでは 10,000 面のダイスロールが発生します。

備考

Discord 上で @ysakasin さんに実装方針を相談済みです。

@codecov
Copy link

codecov bot commented May 2, 2022

Codecov Report

Merging #544 (19d6070) into master (d24c5ad) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #544      +/-   ##
==========================================
+ Coverage   95.54%   95.57%   +0.03%     
==========================================
  Files         320      323       +3     
  Lines       18747    18898     +151     
==========================================
+ Hits        17911    18062     +151     
  Misses        836      836              
Impacted Files Coverage Δ
lib/bcdice/randomizer.rb 100.00% <100.00%> (ø)
lib/bcdice/game_system/StrangerOfSwordCity.rb 96.72% <0.00%> (-1.32%) ⬇️
lib/bcdice/game_system.rb 100.00% <0.00%> (ø)
lib/bcdice/game_system/FutariSousa.rb 100.00% <0.00%> (ø)
lib/bcdice/game_system/DarkDaysDrive.rb 100.00% <0.00%> (ø)
lib/bcdice/game_system/ShuumatsuKikou.rb 100.00% <0.00%> (ø)
lib/bcdice/game_system/Ayabito.rb 100.00% <0.00%> (ø)
lib/bcdice/game_system/Shiranui.rb 100.00% <0.00%> (ø)
lib/bcdice/game_system/Elysion.rb 99.64% <0.00%> (+0.01%) ⬆️
lib/bcdice/dice_table/d66_table.rb 100.00% <0.00%> (+4.54%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d24c5ad...19d6070. Read the comment docs.

Copy link
Member

@ysakasin ysakasin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1d10000 が実行できるかのテストも追加してください

@ViVi-shark
Copy link
Contributor Author

追加しました 19d6070

Copy link
Member

@ysakasin ysakasin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ysakasin ysakasin merged commit f3edea0 into bcdice:master May 2, 2022
@ysakasin
Copy link
Member

ysakasin commented May 2, 2022

@ViVi-shark ありがとうございます! マージしました。

@ViVi-shark ViVi-shark deleted the feature/increase_UPPER_LIMIT_DICE_SIDES branch May 6, 2022 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants