Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Monotone Museum Korean] Update newly added results #518

Merged
merged 12 commits into from
Dec 1, 2021

Conversation

jbblily
Copy link
Contributor

@jbblily jbblily commented Nov 29, 2021

Translated newly added chart result. Please take a look if it has any problem. Thank you.

@codecov
Copy link

codecov bot commented Nov 29, 2021

Codecov Report

Merging #518 (fbf780f) into master (750f1f4) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #518   +/-   ##
=======================================
  Coverage   95.51%   95.51%           
=======================================
  Files         318      318           
  Lines       18637    18637           
=======================================
  Hits        17801    17801           
  Misses        836      836           
Impacted Files Coverage Δ
lib/bcdice/game_system/MonotoneMuseum_Korean.rb 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 750f1f4...fbf780f. Read the comment docs.

i18n/MonotoneMuseum/ko_kr.yml Outdated Show resolved Hide resolved
jbblily and others added 2 commits November 30, 2021 12:10
Too shallow line

Co-authored-by: Kosuke Yamashita <[email protected]>
Copy link
Member

@ochaochaocha3 ochaochaocha3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some tests have failed due to the syntax error in test/data/MonotoneMuseum_Korean.toml and trailing spaces in i18n/MonotoneMuseum/ko_kr.yml. Please confirm these files.

If you have a Ruby environment, running rake test helps you fix the translation file and the test data file.

test/data/MonotoneMuseum_Korean.toml Outdated Show resolved Hide resolved
i18n/MonotoneMuseum/ko_kr.yml Show resolved Hide resolved
i18n/MonotoneMuseum/ko_kr.yml Outdated Show resolved Hide resolved
i18n/MonotoneMuseum/ko_kr.yml Outdated Show resolved Hide resolved
i18n/MonotoneMuseum/ko_kr.yml Outdated Show resolved Hide resolved
i18n/MonotoneMuseum/ko_kr.yml Outdated Show resolved Hide resolved
i18n/MonotoneMuseum/ko_kr.yml Outdated Show resolved Hide resolved
i18n/MonotoneMuseum/ko_kr.yml Outdated Show resolved Hide resolved
i18n/MonotoneMuseum/ko_kr.yml Outdated Show resolved Hide resolved
i18n/MonotoneMuseum/ko_kr.yml Outdated Show resolved Hide resolved
jbblily and others added 7 commits December 1, 2021 00:41
Co-authored-by: Kosuke Yamashita <[email protected]>
Co-authored-by: Kosuke Yamashita <[email protected]>
Co-authored-by: Kosuke Yamashita <[email protected]>
Co-authored-by: Kosuke Yamashita <[email protected]>
Co-authored-by: Kosuke Yamashita <[email protected]>
@jbblily
Copy link
Contributor Author

jbblily commented Dec 1, 2021

Sorry for lots of errors... I deleted all the tabs at the end of the sentences, and also some typos not matching to test script.
I hope it helps...

Copy link
Member

@ochaochaocha3 ochaochaocha3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your fixes seem good to me. Thank you for your cooperation!

@ysakasin ysakasin merged commit 78b0ac8 into bcdice:master Dec 1, 2021
@ysakasin
Copy link
Member

ysakasin commented Dec 1, 2021

@jbblily Awesome work! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants