-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Monotone Museum Korean] Update newly added results #518
Conversation
Codecov Report
@@ Coverage Diff @@
## master #518 +/- ##
=======================================
Coverage 95.51% 95.51%
=======================================
Files 318 318
Lines 18637 18637
=======================================
Hits 17801 17801
Misses 836 836
Continue to review full report at Codecov.
|
Too shallow line Co-authored-by: Kosuke Yamashita <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some tests have failed due to the syntax error in test/data/MonotoneMuseum_Korean.toml
and trailing spaces in i18n/MonotoneMuseum/ko_kr.yml
. Please confirm these files.
If you have a Ruby environment, running rake test
helps you fix the translation file and the test data file.
Co-authored-by: Kosuke Yamashita <[email protected]>
Co-authored-by: Kosuke Yamashita <[email protected]>
Co-authored-by: Kosuke Yamashita <[email protected]>
Co-authored-by: Kosuke Yamashita <[email protected]>
Co-authored-by: Kosuke Yamashita <[email protected]>
Sorry for lots of errors... I deleted all the tabs at the end of the sentences, and also some typos not matching to test script. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your fixes seem good to me. Thank you for your cooperation!
@jbblily Awesome work! Thanks! |
Translated newly added chart result. Please take a look if it has any problem. Thank you.