Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DoubleCross]面数指定なしのダイスをを10面に変更 #513

Merged
merged 2 commits into from
Nov 23, 2021

Conversation

spore0814
Copy link
Contributor

問題点

「3D」のように面数を省略したとき、今までは6面ダイスが振られていたが、ダブルクロス2nd,3rdにおいては、使用するダイスは10面である。

変更内容

sides_implicit_dに10を指定することで、面数を省略したときに10面ダイスが振られるようにした。

@codecov
Copy link

codecov bot commented Nov 20, 2021

Codecov Report

Merging #513 (56337cf) into master (667477c) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 56337cf differs from pull request most recent head a7231dc. Consider uploading reports for the commit a7231dc to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #513   +/-   ##
=======================================
  Coverage   95.50%   95.50%           
=======================================
  Files         318      318           
  Lines       18635    18638    +3     
=======================================
+ Hits        17798    17801    +3     
  Misses        837      837           
Impacted Files Coverage Δ
lib/bcdice/game_system/DoubleCross.rb 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 667477c...a7231dc. Read the comment docs.

@spore0814 spore0814 changed the title [DoubleCross]nDを10面に変更 [DoubleCross]面数指定なしのダイスをを10面に変更 Nov 20, 2021
Copy link
Member

@ochaochaocha3 ochaochaocha3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

動作は問題ないと思います。

@ysakasin マージ前に test/data/DoubleCross.toml の末尾の改行挿入が必要でしょうか?

@GenKuzumochi
Copy link
Contributor

影響が大きいので提案はとどまっていたのですが、最近ダブルクロスしたり、プレイヤーに聞いても10面ダイス標準で問題なさそうですので賛成します。

なにかのはずみでエディタが追加して、別PRに紛れる可能性があるので今のうちに末尾改行はあったほうが良いかと思います。

@ysakasin ysakasin merged commit f2d40ef into bcdice:master Nov 23, 2021
@ysakasin
Copy link
Member

@spore0814 ありがとうございます! マージしました

@ochaochaocha3 @GenKuzumochi レビューと補足thx!

@spore0814 spore0814 deleted the DoubleCross_Side branch November 24, 2021 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants