Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo to StellarLife #491

Merged
merged 1 commit into from
Aug 15, 2021

Conversation

ViVi-shark
Copy link
Contributor

主旨

 『ステラーライフTRPG』のシステム名( = ファイル名・クラス名・ID)のアルファベット表記が正しくないと思われたのを修正。

修正後のアルファベット表記の根拠

(元の表記はどう見てもこのゲームと無関係な英単語と一致しているので、すくなくとも元の表記は誤りと思われる)

備考

 他システムとのアルファベット順ソートの結果は、修正前後で変化しなかった。

@codecov
Copy link

codecov bot commented Aug 15, 2021

Codecov Report

Merging #491 (2b0db98) into master (c833464) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #491   +/-   ##
=======================================
  Coverage   95.40%   95.40%           
=======================================
  Files         296      296           
  Lines       18932    18932           
=======================================
  Hits        18062    18062           
  Misses        870      870           
Impacted Files Coverage Δ
lib/bcdice/game_system.rb 100.00% <100.00%> (ø)
lib/bcdice/game_system/StellarLife.rb 74.82% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c833464...2b0db98. Read the comment docs.

Copy link
Member

@ysakasin ysakasin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ysakasin ysakasin merged commit 40c3a2c into bcdice:master Aug 15, 2021
@ViVi-shark ViVi-shark deleted the feature/fix_typo_to_StellarLife branch August 22, 2021 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants