Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[StellarKnights] 数式解釈時の round_type 指定が不適切だったのを修正 #481

Merged

Conversation

ViVi-shark
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Jun 25, 2021

Codecov Report

Merging #481 (5bee07c) into master (8f24f72) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 5bee07c differs from pull request most recent head 6164702. Consider uploading reports for the commit 6164702 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #481   +/-   ##
=======================================
  Coverage   95.35%   95.35%           
=======================================
  Files         292      292           
  Lines       18744    18744           
=======================================
  Hits        17874    17874           
  Misses        870      870           
Impacted Files Coverage Δ
lib/bcdice/game_system/StellarKnights.rb 98.86% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f24f72...6164702. Read the comment docs.

Copy link
Member

@ysakasin ysakasin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!

@ysakasin ysakasin merged commit ebe0133 into bcdice:master Jun 25, 2021
@ViVi-shark ViVi-shark deleted the features/fix_round_type-Stellarknights branch August 22, 2021 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants