Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[StellarKnights] success/failure を明示 #425

Merged

Conversation

ViVi-shark
Copy link
Contributor

#423


対象

 成功/失敗の概念があるのは、【アタック判定】に防御力との比較が指定された場合のみであるはず。

方針

 当該の【アタック判定】において、成功数が1以上ならば成功、成功数が0ならば失敗とみなす。

 基本ルールブック『銀剣のステラナイツ』の時点では「失敗」という表現はもちいられていないが(同書p150)、『銀剣のステラナイツ 星屑のリヴラガーデン』p119では同じ意味合いの処理に対して「失敗」という表現がされているため、この方針で妥当だと考える。

備考

 成功数が 0 になるテストケースがもともとなかったので、それも追加してある。

@codecov
Copy link

codecov bot commented Apr 20, 2021

Codecov Report

Merging #425 (5887761) into master (2df3312) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #425      +/-   ##
==========================================
+ Coverage   95.14%   95.18%   +0.03%     
==========================================
  Files         286      287       +1     
  Lines       18471    18594     +123     
==========================================
+ Hits        17575    17699     +124     
+ Misses        896      895       -1     
Impacted Files Coverage Δ
lib/bcdice/game_system/StellarKnights.rb 98.73% <100.00%> (+0.10%) ⬆️
lib/bcdice/game_system.rb 100.00% <0.00%> (ø)
...cdice/game_system/sword_world/transcendent_test.rb 100.00% <0.00%> (ø)
lib/bcdice/game_system/SkynautsBouken.rb 100.00% <0.00%> (ø)
lib/bcdice/game_system/SwordWorld.rb 97.35% <0.00%> (+0.09%) ⬆️
lib/bcdice/game_system/MonotoneMuseum.rb 98.30% <0.00%> (+1.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2df3312...5887761. Read the comment docs.

成功数が 0 になるテストケースがなかったので、それは追加してある。
@ViVi-shark ViVi-shark force-pushed the features/stellarknights-indicate_result branch from a9a2699 to e02155d Compare April 21, 2021 04:51
Copy link
Member

@ysakasin ysakasin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます! テストデータの部分にコメントしましたので修正お願いします。

test/data/StellarKnights.toml Outdated Show resolved Hide resolved
test/data/StellarKnights.toml Outdated Show resolved Hide resolved
@ViVi-shark
Copy link
Contributor Author

@ysakasin

 ご確認ありがとうございます。そのまま採用しました。

Copy link
Member

@ysakasin ysakasin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます!

@ysakasin ysakasin merged commit 33dcf71 into bcdice:master Apr 22, 2021
@ViVi-shark ViVi-shark deleted the features/stellarknights-indicate_result branch May 4, 2021 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants