Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ガラコの判定の目標値を省略可能に #378

Merged
merged 1 commit into from
Feb 10, 2021

Conversation

GenKuzumochi
Copy link
Contributor

GRGR+5#2のように、目標値が無くても振れるように

@codecov
Copy link

codecov bot commented Feb 2, 2021

Codecov Report

Merging #378 (1a268fe) into master (8b33e7b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #378   +/-   ##
=======================================
  Coverage   94.47%   94.47%           
=======================================
  Files         272      272           
  Lines       18494    18494           
=======================================
  Hits        17473    17473           
  Misses       1021     1021           
Impacted Files Coverage Δ
lib/bcdice/game_system/Garako.rb 98.46% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b33e7b...9eb1f79. Read the comment docs.

Copy link
Member

@ysakasin ysakasin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ysakasin ysakasin merged commit 15f48fe into bcdice:master Feb 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants