Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ガラコと破戒の塔ダイスボット改良 #308

Merged
merged 8 commits into from
Dec 11, 2020

Conversation

GenKuzumochi
Copy link
Contributor

GRコマンドを拡充

  • 目標値のないダイスロール
  • 柔軟なModifier
  • 不安定(バッドステータス)による自動失敗に対応

ダメージチャートを拡充

  • CDC1+1 などの算術演算
  • CDC0で「ダメージを受けない」と表示するように修正(以前は1ダメージを参照するようになっていたが、誤りと思われる)
  • xDTでダメージチャートVer2に対応

GHAコマンドを追加

  • ダメージ算出+HITコマンド

@codecov
Copy link

codecov bot commented Nov 24, 2020

Codecov Report

Merging #308 (b386c62) into master (603f553) will decrease coverage by 0.15%.
The diff coverage is 91.38%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #308      +/-   ##
==========================================
- Coverage   93.58%   93.43%   -0.16%     
==========================================
  Files         241      248       +7     
  Lines       17571    17949     +378     
==========================================
+ Hits        16444    16770     +326     
- Misses       1127     1179      +52     
Impacted Files Coverage Δ
lib/bcdice/game_system/ShoujoTenrankai.rb 100.00% <ø> (ø)
lib/bcdice/arithmetic/node.rb 69.23% <69.23%> (ø)
lib/bcdice/common_command/reroll_dice/parser.rb 80.59% <80.59%> (ø)
.../bcdice/dice_table/sai_fic_skill_table/category.rb 92.30% <92.30%> (ø)
lib/bcdice/game_system/Emoklore.rb 94.64% <94.64%> (ø)
lib/bcdice/common_command/add_dice/parser.rb 97.05% <96.96%> (+0.18%) ⬆️
lib/bcdice/game_system/Garako.rb 98.41% <97.36%> (+2.25%) ⬆️
lib/bcdice/common_command/reroll_dice/node.rb 97.80% <97.80%> (ø)
lib/bcdice/base.rb 95.67% <100.00%> (+0.62%) ⬆️
lib/bcdice/common_command/add_dice/node.rb 98.95% <100.00%> (-0.46%) ⬇️
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 603f553...4d391ba. Read the comment docs.

Copy link
Member

@ysakasin ysakasin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PRありがとうございます! 下記、修正お願いします。

lib/bcdice/game_system/Garako.rb Outdated Show resolved Hide resolved
lib/bcdice/game_system/Garako.rb Outdated Show resolved Hide resolved
lib/bcdice/game_system/Garako.rb Outdated Show resolved Hide resolved
lib/bcdice/game_system/Garako.rb Outdated Show resolved Hide resolved
GenKuzumochi and others added 3 commits December 2, 2020 16:29
DAMAGE_CHARTS_V2を統合
GRnを一旦廃止(GR+nを使う)
@ysakasin ysakasin merged commit 5cba97e into bcdice:master Dec 11, 2020
@ysakasin
Copy link
Member

コマンドの改善ありがとうございます。マージしました

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants