新クトゥルフ神話TRPGでTens D10を先に振るようにする #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
結果ダイスを画像で表示させた時に十の位のダイスが先にある方が 視認しやすいため、Tens D10を先に実行する。
Codecov Report
@@ Coverage Diff @@
## master #267 +/- ##
==========================================
- Coverage 87.88% 87.88% -0.01%
==========================================
Files 225 225
Lines 22905 22902 -3
==========================================
- Hits 20131 20128 -3
Misses 2774 2774
Continue to review full report at Codecov.
|
ochaochaocha3
requested changes
Aug 23, 2020
src/diceBot/Cthulhu7th.rb
Outdated
Comment on lines
151
to
152
| dice_list = tens_list.map { |tens| tens + ones } | ||
| dice_list.map! { |dice| dice == 0 ? 100 : dice } |
There was a problem hiding this comment.
連続で map しているので、ひとつにまとめられないでしょうか？
Suggested change
| dice_list = tens_list.map { |tens| tens + ones } | |
| dice_list.map! { |dice| dice == 0 ? 100 : dice } | |
| dice_list = tens_list.map { |tens| | |
| dice = tens + ones | |
| dice == 0 ? 100 : dice | |
| } |
There was a problem hiding this comment.
mapの中で複数のことをやると読みづらいだろう思って分割していましたが、大丈夫そうなのでまとめました
ysakasin
added a commit
that referenced
this pull request
Aug 30, 2020
新クトゥルフ神話TRPGでTens D10を先に振るようにする
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ボーナスダイス処理時に今までは一の位を先にダイスロールしていた。
しかし、結果ダイスを画像で表示させた時に十の位のダイスが先にある方が視認しやすいため、Tens D10を先に実行する。