Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NightWizardにプラーナ補正を実装 #255

Merged
merged 2 commits into from
Aug 13, 2020
Merged

Conversation

ysakasin
Copy link
Member

Discordで要望があったため以下の機能追加する。

$ で消費プラーナ数を指定する。
消費した数だけ6面ダイスを振り、達成値に出目を合計する。

ファンブルの場合にはプラーナ消費による補正は発生しない。

`$` で消費プラーナ数を指定する。
消費した数だけ6面ダイスを振り、達成値に出目を合計する。

ファンブルの場合にはプラーナ消費による補正は発生しない。
@ysakasin ysakasin added the enhance dicebot ダイスボットへの機能追加 label Aug 13, 2020
@ysakasin ysakasin requested a review from ochaochaocha3 August 13, 2020 11:29
@codecov
Copy link

codecov bot commented Aug 13, 2020

Codecov Report

Merging #255 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #255   +/-   ##
=======================================
  Coverage   88.01%   88.01%           
=======================================
  Files         224      224           
  Lines       23270    23277    +7     
=======================================
+ Hits        20481    20488    +7     
  Misses       2789     2789           
Impacted Files Coverage Δ
src/diceBot/Cthulhu7th.rb 99.60% <100.00%> (ø)
src/diceBot/NightWizard.rb 98.21% <100.00%> (+0.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 713dc2b...2fcf3ff. Read the comment docs.

Copy link
Member

@ochaochaocha3 ochaochaocha3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

問題ないと思います。

@ysakasin ysakasin merged commit 26b92ce into master Aug 13, 2020
@ysakasin ysakasin deleted the NightWizard_prana branch August 13, 2020 15:12
ysakasin added a commit that referenced this pull request Aug 30, 2020
* NightWizardにプラーナ補正を実装

`$` で消費プラーナ数を指定する。
消費した数だけ6面ダイスを振り、達成値に出目を合計する。

ファンブルの場合にはプラーナ消費による補正は発生しない。

* ヘルプメッセージの誤植修正
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhance dicebot ダイスボットへの機能追加
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants