Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cthulhu7th] ボーナスダイスの表記を拡張して CC+1 を許容する #253

Merged
merged 1 commit into from
Aug 10, 2020

Conversation

ysakasin
Copy link
Member

CC(-1), CC-1, CC(+1) は処理されるのに CC+1 が処理されないのは困惑するという意見があった。
コマンドの対称性を維持するため、 CC+1 と書けるようにする。

元々 CC(+1) は想定されておらず、CC(1)が想定されている。
しかし、カッコの事前処理によって (+1) と (1) がどちらも 1 に置き換えられるためこうなっている。

@ysakasin ysakasin requested a review from ochaochaocha3 August 10, 2020 02:20
@codecov
Copy link

codecov bot commented Aug 10, 2020

Codecov Report

Merging #253 into master will increase coverage by 0.14%.
The diff coverage is 98.16%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #253      +/-   ##
==========================================
+ Coverage   87.86%   88.00%   +0.14%     
==========================================
  Files         220      224       +4     
  Lines       22942    23269     +327     
==========================================
+ Hits        20158    20478     +320     
- Misses       2784     2791       +7     
Impacted Files Coverage Δ
src/diceBot/DiceBotLoaderList.rb 100.00% <ø> (ø)
src/diceBot/Fiasco_Korean.rb 96.55% <96.55%> (ø)
src/diceBot/GoblinSlayer.rb 97.05% <97.05%> (ø)
src/diceBot/StratoShout_Korean.rb 97.72% <97.72%> (ø)
src/diceBot/DoubleCross_Korean.rb 99.08% <99.08%> (ø)
src/bcdiceCore.rb 81.60% <100.00%> (ø)
src/configBcDice.rb 100.00% <100.00%> (ø)
src/diceBot/Cthulhu7th.rb 99.60% <100.00%> (ø)
src/diceBot/Nechronica.rb 97.59% <100.00%> (+0.12%) ⬆️
src/diceBot/VampireTheMasquerade5th.rb 98.50% <100.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c830596...def1a47. Read the comment docs.

Copy link
Member

@ochaochaocha3 ochaochaocha3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

問題ないと思います! 同じ意味で括弧を入力する手間を省けるので、これは良いですね。

@ysakasin ysakasin merged commit 1440fdb into master Aug 10, 2020
@ysakasin ysakasin deleted the cthulhu7th_bonus_dice branch August 10, 2020 09:08
ysakasin added a commit that referenced this pull request Aug 30, 2020
[Cthulhu7th] ボーナスダイスの表記を拡張して CC+1 を許容する
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants