ナイトウィザードのリファクタリング #252
Merged
ナイトウィザードのリファクタリング #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #252 +/- ##
==========================================
+ Coverage 87.86% 88.01% +0.14%
==========================================
Files 220 224 +4
Lines 22942 23270 +328
==========================================
+ Hits 20158 20481 +323
- Misses 2784 2789 +5
Continue to review full report at Codecov.
|
src/utils/format.rb
Outdated
| # | ||
| # @param number [Integer] | ||
| # @return [String] | ||
| def modify_number(number) |
There was a problem hiding this comment.
英語では一単語のmodifierの方が自然だと思います。
Terms used to play role-playing games
- Modifier: A number added to or subtracted from a die roll.
src/diceBot/NightWizard.rb
Outdated
| # @return [Symbol, nil] 比較演算子 | ||
| # @!attribute target_number | ||
| # @return [Integer, nil] 目標値 | ||
| attr_accessor :critical_numbers, :fumble_numbers, :active_modify_number, :cmp_op, :target_number |
There was a problem hiding this comment.
このままで動作上は問題ないですが、@!attribute はやむを得ない場合（例えばメタプログラミングで動的にメソッドが定義されるとき）のみ使用するように書かれているので、単純に以下のように書くのはいかがでしょうか。重複もなくなります。
# @return [Array<Integer>] クリティカルになる出目の一覧
attr_accessor :critical_numbers
# @return [Array<Integer>] ファンブルになる出目の一覧
attr_accessor :fumble_numbers
# ...
# @return [Integer, nil] 目標値
attr_accessor :target_numberThere was a problem hiding this comment.
@return が使えたんですね！
この記法でかけるならこちらの方が読みやすいので修正しました。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
やったこと
DiceBot#changeTextでの変換をしない追加機能のための布石としてのリファクタリング
NWコマンドの仕様概要
@6,7,9のように指定する#3,5