Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AFF2e: should be told a critical hit or fumble. #237

Merged
merged 2 commits into from
Jul 8, 2020
Merged

AFF2e: should be told a critical hit or fumble. #237

merged 2 commits into from
Jul 8, 2020

Conversation

opparco
Copy link
Contributor

@opparco opparco commented Jul 8, 2020

戦闘ロールで強打またはファンブルが発生した場合はそれを伝えるべきです。

@raa0121
Copy link
Contributor

raa0121 commented Jul 8, 2020

文字列を返すようなメソッドで、 nil を返すなら、 '' 空文字列を返したほうが良いと思います。

@opparco
Copy link
Contributor Author

opparco commented Jul 8, 2020

はい。いつもStringを返すと良いですね。Array#compactを使いたかっただけでした。

@ysakasin ysakasin merged commit 0a74394 into bcdice:master Jul 8, 2020
@ysakasin
Copy link
Member

ysakasin commented Jul 8, 2020

@opparco マージしました
nilを返してArray#compactにかけるのはもはやイデオムとなっているので、とても良いと思います。

@opparco opparco deleted the feature-AFF2e-FR-crit branch July 9, 2020 17:09
ysakasin added a commit that referenced this pull request Aug 30, 2020
AFF2e: should be told a critical hit or fumble.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants