Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

一部の加算ダイスでシークレットにならない問題を修正 #230

Merged
merged 2 commits into from
Jul 6, 2020

Conversation

ysakasin
Copy link
Member

@ysakasin ysakasin commented Jul 4, 2020

加算ダイスの先頭がダイスロールリテラルでない時に加算ダイスと認識しない問題があった

加算ダイスの先頭がダイスロールリテラルでない時に加算ダイスと認識しない問題があった
@ysakasin ysakasin added the bug バグってる! label Jul 4, 2020
@ysakasin ysakasin requested a review from ochaochaocha3 July 4, 2020 13:55
@codecov-commenter
Copy link

Codecov Report

Merging #230 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #230   +/-   ##
=======================================
  Coverage   87.67%   87.67%           
=======================================
  Files         218      218           
  Lines       22458    22459    +1     
=======================================
+ Hits        19690    19691    +1     
  Misses       2768     2768           
Impacted Files Coverage Δ
src/bcdiceCore.rb 81.60% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf8ead5...aada47c. Read the comment docs.

Copy link
Member

@ochaochaocha3 ochaochaocha3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

従来の正規表現に問題があったことを確認できました。修正後で問題ないと思います。

@ysakasin ysakasin merged commit 7f5781d into master Jul 6, 2020
@ysakasin ysakasin deleted the fix_secret_add_dice branch July 6, 2020 14:46
ysakasin added a commit that referenced this pull request Aug 30, 2020
* 一部の加算ダイスでシークレットにならない問題を修正

加算ダイスの先頭がダイスロールリテラルでない時に加算ダイスと認識しない問題があった

* For Ruby 1.8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug バグってる!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants