Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GUI関連のファイルを削除する #223

Merged
merged 1 commit into from
Jun 30, 2020
Merged

GUI関連のファイルを削除する #223

merged 1 commit into from
Jun 30, 2020

Conversation

ysakasin
Copy link
Member

IRC botとしての機能はbcdice-ircに移譲したため、元々動作していなかったGUI関連のコードを削除する。

削除したのは以下の通り

  • GUI
  • Iniおよび、その設定読み込みロジック
  • 実行ファイル作成スクリプト

Ref. #222

@ysakasin
Remove GUI
ad11820 
Remove followings
- GUI
- Ini Setting
- Exe file builder
@ysakasin ysakasin requested a review from ochaochaocha3 June 28, 2020 10:20
ochaochaocha3
ochaochaocha3 approved these changes Jun 30, 2020
View reviewed changes
Copy link
Member

@ochaochaocha3 ochaochaocha3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

問題ないと思います。続けてIRC関連のファイルや設定の削除が行えそうです。

@ysakasin ysakasin merged commit fcbfd5b into master Jun 30, 2020
@ysakasin ysakasin deleted the remove-gui branch June 30, 2020 12:25
@ysakasin ysakasin mentioned this pull request Jul 1, 2020
Merged
@ochaochaocha3 ochaochaocha3 added IRCボット分離独立化 IRCボット分離独立化のための作業 refactoring 内部構造の改良 labels Jul 1, 2020
ysakasin added a commit that referenced this pull request Aug 30, 2020
@ysakasin
Merge pull request #223 from bcdice/remove-gui
31e6803 
GUI関連のファイルを削除する
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ochaochaocha3 ochaochaocha3 ochaochaocha3 approved these changes

Assignees
No one assigned
Labels
IRCボット分離独立化 IRCボット分離独立化のための作業 refactoring 内部構造の改良
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ysakasin @ochaochaocha3