Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

アニマアニムスのダイスボットを追加 #221

Merged
merged 5 commits into from
Jun 26, 2020

Conversation

spore0814
Copy link
Contributor

アニマアニムス( http://www.fear.co.jp/animaanimus/product.htm )のダイスボットを追加しました。

行為判定に関するコマンドと表を2つ実装しました。
ご確認のほどお願いいたします。

@ysakasin
Copy link
Member

@spore0814 寄稿ありがとうございます!

提案していただいている 2+5AN の形式だと、 25AN の和だと誤認してしまうと思います。
このような書式でダイス数の補正をするコマンドは、現状のBCDiceには無いと認識しています。

以下2つのどちらかの書式が良いと思うのですがどうでしょうか。

  • xAN
    • ダイス数に補正があるときには (x+y)AN と書いてもらう。
  • ANx+y
    • 妥協案ではありますが、x+yANよりは誤認しづらいと思います。

@ysakasin ysakasin added the new dicebot 新システムの対応 label Jun 24, 2020
@codecov-commenter
Copy link

Codecov Report

Merging #221 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #221      +/-   ##
==========================================
+ Coverage   87.59%   87.61%   +0.01%     
==========================================
  Files         216      217       +1     
  Lines       22375    22411      +36     
==========================================
+ Hits        19600    19636      +36     
  Misses       2775     2775              
Impacted Files Coverage Δ
src/diceBot/AnimaAnimus.rb 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80559e0...9ac2e9e. Read the comment docs.

src/diceBot/AnimaAnimus.rb Outdated Show resolved Hide resolved
src/diceBot/AnimaAnimus.rb Outdated Show resolved Hide resolved
spore0814 and others added 2 commits June 26, 2020 13:38
@spore0814
Copy link
Contributor Author

修正ありがとうございます、取り込みました。

Copy link
Member

@ysakasin ysakasin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

良いと思います!

@ysakasin ysakasin merged commit 175ff7a into bcdice:master Jun 26, 2020
@ysakasin
Copy link
Member

寄稿ありがとうございます。マージしました。

ysakasin added a commit that referenced this pull request Aug 30, 2020
アニマアニムスのダイスボットを追加
@spore0814 spore0814 deleted the add_AnimaAnimus branch October 27, 2020 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new dicebot 新システムの対応
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants