Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extratablesを復活 #140

Merged
merged 1 commit into from
Mar 25, 2020
Merged

Extratablesを復活 #140

merged 1 commit into from
Mar 25, 2020

Conversation

ysakasin
Copy link
Member

BCDice内部ではExtratablesを利用しなくなったため、 #43, #50 などでサポートから外したが、どどんとふで BCDice#getTableDataResult などを利用していたため、復活させる

@ysakasin ysakasin added the bug バグってる! label Mar 24, 2020
@ysakasin ysakasin requested a review from ochaochaocha3 March 24, 2020 11:01
Copy link
Member

@ochaochaocha3 ochaochaocha3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#43 の元の状態に戻っているので,大丈夫だと思います.

@ysakasin ysakasin merged commit c1b9a22 into master Mar 25, 2020
@ysakasin ysakasin deleted the resurrect_extratables branch March 25, 2020 12:36
ysakasin added a commit that referenced this pull request Aug 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug バグってる!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants