WorldOfDarkness: fix. add STA for 20th Ed. #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #137 +/- ##
=======================================
Coverage 86.30% 86.30%
=======================================
Files 192 192
Lines 22263 22266 +3
=======================================
+ Hits 19214 19217 +3
Misses 3049 3049
Continue to review full report at Codecov.
|
ysakasin
requested changes
Mar 17, 2020
src/diceBot/WorldOfDarkness.rb
Outdated
Comment on lines
91
to
97
| dice = Array.new(dice_pool) | ||
|
|
||
| diceResults[i] = dice_now | ||
| # FIXME: まとめて振る | ||
| dice_pool.times do |i| | ||
| dice_now, = roll(1, 10) | ||
| dice[i] = dice_now | ||
| end |
There was a problem hiding this comment.
Array.new にブロックを渡すと、配列のサイズ分ブロックを実行し、戻り値を配列の要素にしてくれます
Array.new(2) { |i| i*2 } #=> [0,2]
ysakasin
requested changes
Mar 17, 2020
ysakasin
added a commit
that referenced
this pull request
Aug 30, 2020
* WorldOfDarkness: fix. add STA for 20th Ed. * WorldOfDarkness: allow diff=2 * WorldOfDarkness: refactor * WorldOfDarkness: refactor * WorldOfDarkness: fix * Remove unused block variable Co-authored-by: SAKATA Sinji <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
原作者による2018-11-25版のtest caseを基に書き換えました。