Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

import AFF2e #135

Merged
merged 4 commits into from
Mar 14, 2020
Merged

import AFF2e #135

merged 4 commits into from
Mar 14, 2020

Conversation

opparco
Copy link
Contributor

@opparco opparco commented Mar 13, 2020

ADVANCED FIGHTING FANTASY 2nd Edition 向けのdiceBotを書きました。

Copy link
Member

@ysakasin ysakasin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

寄稿ありがとうございます! いくつか手直しして欲しい場所があるので、お願いします

src/diceBot/AFF2e.rb Outdated Show resolved Hide resolved
src/diceBot/AFF2e.rb Outdated Show resolved Hide resolved
src/diceBot/AFF2e.rb Outdated Show resolved Hide resolved
src/diceBot/AFF2e.rb Outdated Show resolved Hide resolved
src/diceBot/AFF2e.rb Outdated Show resolved Hide resolved
@ysakasin
Copy link
Member

ysakasin commented Mar 14, 2020

あと、近々ダイスボット名の読み仮名機能が搭載される予定なので、このシステムのヨミをカタカナで教えてください。

#128

@opparco
Copy link
Contributor Author

opparco commented Mar 14, 2020

書籍はこちら:
アドバンスト・ファイティング・ファンタジー第2版
https://www.amazon.co.jp/dp/4883753069

なので
アドバンスト・ファイティング・ファンタジー
中点や版の扱いはお任せします。

@codecov-io
Copy link

codecov-io commented Mar 14, 2020

Codecov Report

Merging #135 into master will increase coverage by 0.03%.
The diff coverage is 96.87%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #135      +/-   ##
==========================================
+ Coverage   86.22%   86.25%   +0.03%     
==========================================
  Files         189      190       +1     
  Lines       22119    22183      +64     
==========================================
+ Hits        19072    19134      +62     
- Misses       3047     3049       +2     
Impacted Files Coverage Δ
src/diceBot/AFF2e.rb 96.87% <96.87%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb9b2e0...f5aed39. Read the comment docs.

Copy link
Member

@ysakasin ysakasin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ysakasin ysakasin merged commit ac12136 into bcdice:master Mar 14, 2020
ysakasin added a commit that referenced this pull request Aug 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants