Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On Exception only log the email ID at error level and log the whole email at trace level #291

Merged
merged 1 commit into from
Sep 30, 2020
Merged

On Exception only log the email ID at error level and log the whole email at trace level #291

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions ...es/simple-java-mail/src/main/java/org/simplejavamail/mailer/internal/SendMailClosure.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,13 +63,16 @@ public void executeClosure() {
TransportRunner.sendMessage(operationalConfig.getClusterKey(), session, message, message.getAllRecipients());
}
} catch (final UnsupportedEncodingException e) {
LOGGER.error("Failed to send email:\n{}", email);
LOGGER.error("Failed to send email:\n{}", email.getId());
LOGGER.trace("{}", email);
throw new MailerException(MailerException.INVALID_ENCODING, e);
} catch (final MessagingException e) {
LOGGER.error("Failed to send email:\n{}", email);
LOGGER.error("Failed to send email:\n{}", email.getId());
LOGGER.trace("{}", email);
throw new MailerException(MailerException.GENERIC_ERROR, e);
} catch (final Exception e) {
LOGGER.error("Failed to send email:\n{}", email);
LOGGER.error("Failed to send email:\n{}", email.getId());
LOGGER.trace("{}", email);
throw e;
}
}
Expand Down