Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't shade the DKIM dependency anymore #120

Closed
bbottema opened this issue Dec 8, 2017 · 2 comments
Closed

Don't shade the DKIM dependency anymore #120

bbottema opened this issue Dec 8, 2017 · 2 comments
Labels
enhancement Priority-High
Milestone
5.0.0

Comments

@bbottema
Copy link
Owner

bbottema commented Dec 8, 2017 •
edited
Loading

Simple Java Mail is now fixed to specific versions of some minor external libraries. However, as the only 3rd party dependency, Markenwerk's dkim library (added for #33) should be depended upon the same as any other dependency rather than being shaded into the jar under a different package.

This solves both #80 and mronager@5b98c85

It might solve the problem for upgrading outdated dependencies. But there are still a few problems:

  • the dkim libraries depend on other libs, which are not included in the shaded jar (at least i had issues with this)
  • it is unclear which dependencies are pulled in, since they dont show in the list
  • it's not possible to exclude dependencies when they are shaded (e.g the outlook lib)
bbottema referenced this issue in mronager/simple-java-mail Dec 8, 2017
Allow optional shading
5b98c85 
Currently this library is bundling a few dependencies, like dkim. Maven
will not pull in transitive dependencies from these, and overriding
these is significantly more difficult. For java9, it also gives clashes
with jigsaw.

This allows the use of -DskipShade, to create an unshaded package.
@bbottema bbottema added this to the 5.0.0 milestone Dec 8, 2017
bbottema added a commit that referenced this issue Dec 24, 2017
@bbottema
#120: updated DKIM library to 1.1.10 and removed it from shading. Mad…
a975a52 
…e it an optional dependency.
@bbottema
Copy link
Owner Author

Issue done, I'm just waiting for a reply from @toKrause on whether the update from 1.1.6 to 1.1.10 might give us any surprises.

@bbottema
Copy link
Owner Author

Released as 5.0.0.rc1-SNAPSHOT. Add OSS' snapshots repo to find it in Maven.

@bbottema bbottema mentioned this issue Feb 16, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Priority-High
Projects
None yet
Milestone
5.0.0
Development

No branches or pull requests
1 participant
@bbottema