Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test against latest Ruby versions #792

Merged
merged 1 commit into from
Dec 27, 2018

Conversation

tagliala
Copy link
Contributor

@tagliala tagliala commented Dec 26, 2018

Test against latest Ruby and JRuby versions

Drop tests against EOL ruby versions:

  • MRI 2.2.10
  • JRuby 9.0.5.0

Add tests against:

  • MRI 2.6.0
  • JRuby 9.2.5.0

@tagliala
Copy link
Contributor Author

tagliala commented Dec 26, 2018

Well, tests against 2.6.0 do not fail on my development machine 🤷‍♂️

Finished in 3 minutes 8.8 seconds (files took 1.98 seconds to load)
4590 examples, 0 failures

/Users/geremia/.rvm/rubies/ruby-2.6.0/bin/ruby -I/Users/geremia/.rvm/gems/ruby-2.6.0/gems/rspec-support-3.8.0/lib:/Users/geremia/.rvm/gems/ruby-2.6.0/gems/rspec-core-3.8.0/lib /Users/geremia/.rvm/gems/ruby-2.6.0/gems/rspec-core-3.8.0/exe/rspec spec/acceptance/net_http/real_net_http_spec.rb -c -f progress -r ./spec/acceptance/net_http/real_net_http_spec.rb
................................

Finished in 0.2645 seconds (files took 0.18309 seconds to load)
32 examples, 0 failures

Loaded suite /Users/geremia/.rvm/rubies/ruby-2.6.0/lib/ruby/gems/2.6.0/gems/rake-12.3.2/lib/rake/rake_test_loader
Started
..............
Finished in 0.01343 seconds.
---------------------------------------------------------------------------------------------------------------------
14 tests, 14 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
---------------------------------------------------------------------------------------------------------------------
1042.44 tests/s, 1042.44 assertions/s
Run options: --seed 29503

# Running:

.....................

Finished in 0.020394s, 1029.7146 runs/s, 2353.6334 assertions/s.
21 runs, 48 assertions, 0 failures, 0 errors, 0 skips
$ rspec ./spec/acceptance/net_http/net_http_spec.rb:312
Run options:
  include {:focus=>true, :locations=>{"./spec/acceptance/net_http/net_http_spec.rb"=>[312]}}
  exclude {:without_webmock=>true}
.

Finished in 0.14053 seconds (files took 0.66589 seconds to load)
1 example, 0 failures

Drop tests against EOL ruby versions:
- MRI 2.2.10
- JRuby 9.0.5.0

Add tests against:
- MRI 2.6.0
- JRuby 9.2.5.0
@tagliala tagliala force-pushed the test-against-ruby-26 branch from 259e3cb to da99b14 Compare December 26, 2018 18:13
@tagliala tagliala changed the title Test against Ruby 2.6.0 Test against latest Ruby versions Dec 26, 2018
@bblimke
Copy link
Owner

bblimke commented Dec 27, 2018

Thank you @tagliala

@bblimke bblimke merged commit 38bf439 into bblimke:master Dec 27, 2018
@tagliala
Copy link
Contributor Author

@bblimke you're welcome, thanks for the release

Do you know what could be the origin of the failure on Travis CI?

@bblimke
Copy link
Owner

bblimke commented Dec 27, 2018

@tagliala I have no idea. On my machine all tests pass on 2.6.0. Perhaps some differences in Ruby build.

@ahorek
Copy link

ahorek commented Dec 27, 2018

It fails for some time only on ruby 2.6 and master not always but pretty often. I'll try to simulate it locally.

@ahorek
Copy link

ahorek commented Dec 27, 2018

I was also unable to simulate it locally, all tests pass... weird

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants