-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accept max_messages param #401
Conversation
One thing to note on this. This worked on my Docker macOS arm64, but failed on prod Ubuntu x86_64 machine with:
I wanted to try out newer LIBSIGNAL_CLIENT_VERSION=0.30.0 but couldn't find where I can get the files for ext/libraries/libsignal-client/v0.31.0. Possibly relevant AsamK/signal-cli#1305 |
Many thanks for the PR! I'll wait until the CI is finished, but to me it looks good! Regarding your issues: Which mode did you use on your x86-64 machine? the native mode? regarding libsignal-client v0.31.0: I always try to stay at the same version that signal-cli comes packaged with. Newer versions might work, but I think it is the safest approach to use the same version as the pre-packaged signal-cli :) |
You're welcome!
Native mode
Gotcha. Where do you see which version it's packaged with? |
One thing I forgot to mention, I would very much appreciate if you'd ping me once this is on Docker Hub. I think it might be something with my image being built differently so I'd love to try out the "official" build. |
ok, then it could indeed be GraalVM related.
It is mentioned in the signal-cli release changelog and verified again in the dockerfile.
I'll try, if I do not forget. You can btw. also watch this github repository for a new release (see https://github.blog/changelog/2018-11-27-watch-releases/). I'll always create a new github release when a new release is ready and the image is pushed to dockerhub. But maybe I can get docker image up for beta testing sooner, in that case I'll let you know :) |
I’m watching all commits and releases so should be good :) |
I was just creating a ticket for this issue. We have been testing out the |
Also upgrades signal cli to 0.12.1 since it failed to build previously (couldn't find signal-cli-native of 0.12.0).
Contributes towards #365