Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept max_messages param #401

Merged
merged 2 commits into from
Aug 31, 2023
Merged

Accept max_messages param #401

merged 2 commits into from
Aug 31, 2023

Conversation

k-bx
Copy link
Contributor

@k-bx k-bx commented Aug 31, 2023

Also upgrades signal cli to 0.12.1 since it failed to build previously (couldn't find signal-cli-native of 0.12.0).

Contributes towards #365

@k-bx
Copy link
Contributor Author

k-bx commented Aug 31, 2023

One thing to note on this. This worked on my Docker macOS arm64, but failed on prod Ubuntu x86_64 machine with:

WARN  Manager - Failed to call libsignal-client: Can't load library: /tmp/1243969752656717

I wanted to try out newer LIBSIGNAL_CLIENT_VERSION=0.30.0 but couldn't find where I can get the files for ext/libraries/libsignal-client/v0.31.0.

Possibly relevant AsamK/signal-cli#1305

@bbernhard
Copy link
Owner

Many thanks for the PR!

I'll wait until the CI is finished, but to me it looks good!

Regarding your issues: Which mode did you use on your x86-64 machine? the native mode?

regarding libsignal-client v0.31.0: I always try to stay at the same version that signal-cli comes packaged with. Newer versions might work, but I think it is the safest approach to use the same version as the pre-packaged signal-cli :)

@k-bx
Copy link
Contributor Author

k-bx commented Aug 31, 2023

You're welcome!

Regarding your issues: Which mode did you use on your x86-64 machine? the native mode?

Native mode

regarding libsignal-client v0.31.0: I always try to stay at the same version that signal-cli comes packaged with. Newer versions might work, but I think it is the safest approach to use the same version as the pre-packaged signal-cli :)

Gotcha. Where do you see which version it's packaged with?

@k-bx
Copy link
Contributor Author

k-bx commented Aug 31, 2023

One thing I forgot to mention, I would very much appreciate if you'd ping me once this is on Docker Hub. I think it might be something with my image being built differently so I'd love to try out the "official" build.

@bbernhard
Copy link
Owner

Native mode

ok, then it could indeed be GraalVM related.

Gotcha. Where do you see which version it's packaged with?

It is mentioned in the signal-cli release changelog and verified again in the dockerfile.

One thing I forgot to mention, I would very much appreciate if you'd ping me once this is on Docker Hub. I think it might be something with my image being built differently so I'd love to try out the "official" build.

I'll try, if I do not forget. You can btw. also watch this github repository for a new release (see https://github.blog/changelog/2018-11-27-watch-releases/). I'll always create a new github release when a new release is ready and the image is pushed to dockerhub. But maybe I can get docker image up for beta testing sooner, in that case I'll let you know :)

@k-bx
Copy link
Contributor Author

k-bx commented Aug 31, 2023

I’m watching all commits and releases so should be good :)

@bbernhard bbernhard merged commit e0e49dc into bbernhard:master Aug 31, 2023
@mattwr18
Copy link
Contributor

mattwr18 commented Sep 26, 2023

I was just creating a ticket for this issue. We have been testing out the 0.68-pre release and ran into the issue with libsignal in native mode as well.

@mattwr18 mattwr18 mentioned this pull request Sep 28, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants