Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setting group_link not having an effect when creating group #410

Closed
2 tasks done
Kuhkaefer opened this issue Sep 20, 2023 · 4 comments
Closed
2 tasks done

setting group_link not having an effect when creating group #410

Kuhkaefer opened this issue Sep 20, 2023 · 4 comments

Comments

@Kuhkaefer
Copy link

Kuhkaefer commented Sep 20, 2023

The problem

When creating a group with
"http://127.0.0.1:8080/v1/groups/PHONE_NUMBER"
and
json={'description': 'string', 'group_link': 'enabled', 'members': ['PHONE_NUMBER'], 'name': 'Test', 'permissions': {'add_members': 'only-admins', 'edit_group': 'only-admins'}}
with group_link = enabled
the group is created, however 'Group link' remains disabled in the new group.

Are you using the latest released version?

  • Yes

Have you read the troubleshooting page?

  • Yes

What type of installation are you running?

signal-cli-rest-api Docker Container

In which mode are you using the docker container?

JSON-RPC Mode

What's the architecture of your host system?

x86-64

Additional information

No response

bbernhard pushed a commit that referenced this issue Sep 26, 2023
link & permissions weren't correctly set

see #410
@bbernhard
Copy link
Owner

should be fixed with the next release

@Kuhkaefer
Copy link
Author

Kuhkaefer commented Sep 29, 2023

I am running the new version (0.68) now, but creating a group with:

curl -X POST -H "Content-Type: application/json" 'http://localhost:8080/v1/groups/MYNUMBER' -d '{"description": "test", "group_link": "enabled", "members": ["MYNUMBER", "ANOTHERNUMBER"], "name": "TestGroup", "permissions": {"add_members": "only-admins", "edit_group": "only-admins"}}'

fails with the following error message of the docker (debug mode switched on):

2023/09/29 22:03:35 [Recovery] 2023/09/29 - 22:03:35 panic recovered:
runtime error: index out of range [3] with length 3                                                                                                            
/usr/local/go/src/runtime/panic.go:113 (0x434c1e)                                                                                                              
/tmp/signal-cli-rest-api-src/client/client.go:55 (0x9cea56)                                                                                                    
/tmp/signal-cli-rest-api-src/client/client.go:707 (0x9ce07e)                                                                                                   
/tmp/signal-cli-rest-api-src/api/api.go:577 (0x9d9953)                                                                                                         
/go/pkg/mod/github.com/gin-gonic/[email protected]/context.go:174 (0x936961)                                                                                          
/go/pkg/mod/github.com/gin-gonic/[email protected]/recovery.go:102 (0x93694c)                                                                                         
/go/pkg/mod/github.com/gin-gonic/[email protected]/context.go:174 (0x935a86)                                                                                          
/go/pkg/mod/github.com/gin-gonic/[email protected]/logger.go:240 (0x935a69)                                                                                           
/go/pkg/mod/github.com/gin-gonic/[email protected]/context.go:174 (0x934aea)                                                                                          
/go/pkg/mod/github.com/gin-gonic/[email protected]/gin.go:620 (0x934771)                                                                                              
/go/pkg/mod/github.com/gin-gonic/[email protected]/gin.go:576 (0x93429c)                                                                                              
/usr/local/go/src/net/http/server.go:2936 (0x701af5)                                                                                                           
/usr/local/go/src/net/http/server.go:1995 (0x6fd011)                                                                                                           
/usr/local/go/src/runtime/asm_amd64.s:1598 (0x4696e0)                                                                                                          
                                                                                                                                                               
[GIN] 2023/09/29 - 22:03:35 | 500 |     244.804µs |      172.17.0.1 | POST     "/v1/groups/MYNUMBER"

@bbernhard
Copy link
Owner

Damn, looks like a broke something. I'll have a look at it after the weekend!

bbernhard pushed a commit that referenced this issue Oct 3, 2023
@Kuhkaefer
Copy link
Author

Wonderful, it is working with 0.69 now! Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants