6ffm70 patch 1 #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rework of #4 (comment) |
bbernhard
reviewed
Oct 20, 2021
| @@ -152,6 +154,10 @@ def print_failed_event(self): | |||
| def print_paused_event(self): | |||
| return self._settings.get_boolean(["printpausedevent"]) | |||
|
|
|||
| @property | |||
| def filament_change_event(self): | |||
| return self._settings.get(["filamentchangeevent"]) | |||
There was a problem hiding this comment.
I just tested your changeset and it works really well!
The only small thing I've found during code review is in this line (line 159) here. I think it would be better to use get_boolean instead of get here. I think this change has no operational impact (at least I couldn't find any), but I think it would be more consistent to use get_boolean here.
Apart from that everything looks fine!
Many thanks for this really nice contribution!
@Property def filament_change_event Your patience and feedback to a learner is much appreciated
|
looks good 🎉 Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
note to self: don't copy code changes from an ssh terminal w/o line break