Reduce zxing dependency in order to fix build issues #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 1.9.13 versions no longer seems to exist in a remote repository, at least any that I, or gradle, can easily find. They were stored in jCenter, which is deprecated, but now appear to be gone. https://mvnrepository.com/artifact/me.dm7.barcodescanner/zxing Looking at the github, it seems there aren't any significant features added after 1.9.8 that we need to use. https://github.com/dm77/barcodescanner I'm trying to build the Android version of Kalium and encountering build issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 1.9.13 version no longer seems to exist in a remote repository, at least any that I, or gradle, can easily find. They were stored in jCenter, which is deprecated, but now appear to be gone. The artifacts 404.
Looking at the github, it seems there aren't any significant features added after 1.9.8 that are important. So I'm hoping the solution can be as simple as dropping down to this version.
I'm trying to build the Android version of Kalium and encountering build issues with finding this transitive dependency.
Related: BananoCoin/kalium_wallet_flutter#57