Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded 400 "Invalid query options" error #79

Merged
merged 2 commits into from
Aug 1, 2024
Merged

Conversation

j616
Copy link
Contributor

@j616 j616 commented Jul 31, 2024

Details

Remove 400 "Invalid query options" error on endpoint that doesn't take query parameters

Pivotal Story (if relevant)

Story URL: https://www.pivotaltracker.com/story/show/188041533

Related PRs

Where appropriate. Indicate order to be merged.

Submitter PR Checks

(tick as appropriate)

  • PR completes task/fixes bug
  • API version has been incremented if necessary
  • ADR status has been updated, and ADR implementation has been recorded
  • Documentation updated (README, etc.)
  • PR added to Pivotal story (if relevant)
  • Follow-up stories added to Pivotal

Reviewer PR Checks

(tick as appropriate)

  • PR completes task/fixes bug
  • Design makes sense, and fits with our current code base
  • Code is easy to follow
  • PR size is sensible
  • Commit history is sensible and tidy

Info on PRs

The checks above are guidelines. They don't all have to be ticked, but they should all have been considered.

@j616 j616 requested a review from a team as a code owner July 31, 2024 13:49
Copy link
Contributor

@philipnbbc philipnbbc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somewhat related, could this 400 description be fixed to refer to the boolean value rather than flow description? Otherwise LGTM

@j616 j616 merged commit 2b9dc6f into main Aug 1, 2024
5 checks passed
@j616 j616 deleted the jamessa-invalidQuery branch August 1, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants