Random object IDs ADR and implementation #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The response of /<flow id>/storage has "segments" renamed to "media_objects" to reflect there is no longer a need for the concept of a storage segment that is distinct from the media object. The request and response have no timeranges. The response no longer has paging headers. Some wording has been changed to use media object instead of "flow segment media object" or "flow segment object" or "storage segment". The start timestamp falling within the storage segment timerange restriction has been removed sem-ver: api-break
philipnbbc
force-pushed
the
philipn-random-object-ids
branch
from
89f0172 to
57df67b
Compare
samdbmg
approved these changes
Mar 22, 2024
Co-authored-by: Sam Mesterton-Gibbons <[email protected]>
Implements part of ADR0012 to make the `get_url` and `put_url` fields in Flow Segments mandatory.
philipnbbc
force-pushed
the
philipn-random-object-ids
branch
from
2030c2b to
2d7f63b
Compare
philipnbbc
force-pushed
the
philipn-random-object-ids
branch
from
2d7f63b to
7443d38
Compare
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This PR proposes a change to the
/<flow-id>/storageendpoint to essentially return a list of PUT URLs for uploading media objects, where each request generates a unique list of object IDs. The segmentation and timeranges restrictions have been removed.The implementation has:
Pivotal Story (if relevant)
Story URL: https://www.pivotaltracker.com/story/show/187193684
Related PRs
Where appropriate. Indicate order to be merged.
Submitter PR Checks
(tick as appropriate)
Reviewer PR Checks
(tick as appropriate)
Info on PRs
The checks above are guidelines. They don't all have to be ticked, but they should all have been considered.