Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make clear that segments cannot overlap #32

Merged
merged 2 commits into from
Mar 15, 2024
Merged

Conversation

samdbmg
Copy link
Member

@samdbmg samdbmg commented Mar 14, 2024

Details

  • Adds a (rejected) ADR covering discussions on whether segments should be allowed to overlap
  • Clarifies the wording in the API spec accordingly

Pivotal Story (if relevant)

Story URL: https://www.pivotaltracker.com/story/show/187200060

Related PRs

N/A

Submitter PR Checks

(tick as appropriate)

  • PR completes task/fixes bug
  • API version has been incremented if necessary
  • ADR status has been updated, and ADR implementation has been recorded
  • Documentation updated (README, etc.)
  • PR added to Pivotal story (if relevant)
  • Follow-up stories added to Pivotal

Reviewer PR Checks

(tick as appropriate)

  • PR completes task/fixes bug
  • Design makes sense, and fits with our current code base
  • Code is easy to follow
  • PR size is sensible
  • Commit history is sensible and tidy

Info on PRs

The checks above are guidelines. They don't all have to be ticked, but they should all have been considered.

samdbmg added 2 commits March 14, 2024 14:28
If the Flow is immutable then once a Flow segment is written it cannot
be re-written, which also means they cannot overlap.

sem-ver: bugfix
@samdbmg samdbmg force-pushed the sammg-segment-overlap branch from eb64a2a to 9e484bf Compare March 14, 2024 14:28
@samdbmg samdbmg marked this pull request as ready for review March 14, 2024 14:28
@samdbmg samdbmg requested a review from a team as a code owner March 14, 2024 14:28
@philipnbbc philipnbbc self-assigned this Mar 15, 2024
Copy link
Contributor

@philipnbbc philipnbbc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@samdbmg samdbmg merged commit fd49dc9 into main Mar 15, 2024
3 checks passed
@samdbmg samdbmg deleted the sammg-segment-overlap branch March 15, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants