Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adr: Add a Flow read-write permissions ADR #24

Merged
merged 3 commits into from
Feb 21, 2024

Conversation

philipnbbc
Copy link
Contributor

Details

This PR is started in draft status to allow feedback before proposing an approach.

Pivotal Story (if relevant)

Story URL: https://www.pivotaltracker.com/story/show/186711250

Related PRs

Where appropriate. Indicate order to be merged.

Submitter PR Checks

(tick as appropriate)

  • PR completes task/fixes bug
  • API version has been incremented if necessary
  • ADR status has been updated, and ADR implementation has been recorded
  • Documentation updated (README, etc.)
  • PR added to Pivotal story (if relevant)
  • Follow-up stories added to Pivotal

Reviewer PR Checks

(tick as appropriate)

  • PR completes task/fixes bug
  • Design makes sense, and fits with our current code base
  • Code is easy to follow
  • PR size is sensible
  • Commit history is sensible and tidy

Info on PRs

The checks above are guidelines. They don't all have to be ticked, but they should all have been considered.

@philipnbbc philipnbbc requested a review from a team February 6, 2024 16:43
@philipnbbc philipnbbc force-pushed the philipn-flow-read-write-permission branch from fa84347 to 67f4cad Compare February 19, 2024 11:41
@philipnbbc philipnbbc marked this pull request as ready for review February 19, 2024 12:01
@philipnbbc philipnbbc marked this pull request as draft February 19, 2024 12:05
If the Flow.read_only property is "true" then implementations should
rejects requests to update, except for this property. Endpoints have
been added as well to make it easier to toggle the property.

sem-ver: feature
@philipnbbc philipnbbc marked this pull request as ready for review February 19, 2024 12:39
@C-Lunn C-Lunn requested review from C-Lunn and removed request for a team February 20, 2024 15:14
Copy link
Contributor

@C-Lunn C-Lunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@philipnbbc philipnbbc merged commit 2f666a1 into main Feb 21, 2024
3 checks passed
@philipnbbc philipnbbc deleted the philipn-flow-read-write-permission branch February 21, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants