Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove .only from describe block #9880

Merged
merged 2 commits into from
Feb 22, 2022
Merged

Conversation

MuhammadAHussain
Copy link
Contributor

@MuhammadAHussain MuhammadAHussain commented Feb 21, 2022

Resolves N/A

Overall change:
Noticed that a missed .only on a describe block; means only a subset of tests were running on that file. Introduced after merging this PR. Removed the .only and fixed two failing tests

Code changes:

  • Remove .only from describe block.
  • Editing test data in the cookie to be JSON string.

  • I have assigned myself to this PR and the corresponding issues
  • I have added the cross-team label to this PR if it requires visibility across World Service teams
  • I have assigned this PR to the Simorgh project
  • (BBC contributors only) This PR follows the repository use guidelines

Testing:

  • Automated (jest and/or cypress) tests added (for new features) or updated (for existing features)
  • If necessary, I have run the local E2E non-smoke tests relevant to my changes (CYPRESS_APP_ENV=local CYPRESS_SMOKE=false yarn test:e2e:interactive)
  • This PR requires manual testing

@MuhammadAHussain MuhammadAHussain self-assigned this Feb 21, 2022
Copy link
Contributor

@DarioR01 DarioR01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some weird GitHub warning in Files changed complaining about sensitive cookies sent without enforcing SSL encryption.

@MuhammadAHussain
Copy link
Contributor Author

LGTM, just some weird GitHub warning in Files changed complaining about sensitive cookies sent without enforcing SSL encryption.

Weird, I don't see the warning. Where abouts is the warning?

@MuhammadAHussain MuhammadAHussain merged commit e8d935f into latest Feb 22, 2022
@MuhammadAHussain MuhammadAHussain deleted the remove-dot-only-from-tests branch February 22, 2022 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants