Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement updated Psammead module to remove the bottom border beneath the top nav #7306

Closed
wants to merge 5 commits into from

Conversation

thekp
Copy link
Contributor

@thekp thekp commented Jul 23, 2020

Resolves #6602

Overall change:

  • Implement psammead-navigation: "^6.0.15" which obscures the line bellow the top nav while maintaining it when the nav breaks across two rows. Psammead PR here: Hide visible pink line below nav element BBC-archive/psammead#3628
  • Bumping a lot of packages because of a dependency chain that revolves around the gel-foundations: 4.2.0 update
  • Updated snaps

  • I have assigned myself to this PR and the corresponding issues
  • I have assigned this PR to the Simorgh project

@thekp thekp self-assigned this Jul 23, 2020
@thekp thekp added ux To be reviewed by UX before merging cross-team For visibility for both World Service teams (Engage & Media) ws-media World Service Media labels Jul 23, 2020
@thekp thekp assigned RichardPK and unassigned thekp Jul 23, 2020
@RichardPK RichardPK changed the title Bump packages Implement updated Psammead module to remove the bottom border beneath the top nav Jul 23, 2020
@RichardPK
Copy link
Contributor

Closed. Original PR ended up working #7305

@RichardPK RichardPK closed this Jul 23, 2020
@RichardPK RichardPK deleted the bumpPackages branch July 23, 2020 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cross-team For visibility for both World Service teams (Engage & Media) ux To be reviewed by UX before merging ws-media World Service Media
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove top navigation bottom border
3 participants