Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cypress test for AMP navigation toggling #4990

Merged
merged 3 commits into from
Jan 2, 2020

Conversation

tochwill
Copy link
Contributor

@tochwill tochwill commented Dec 20, 2019

Resolves #NUMBER

Overall change:
We can't test the AMP state management that handles the toggling of the dropdown menu in unit tests, as the test runner doesn't understand AMP actions. This adds a cypress test to check the toggling works for a small subset of services.

Code changes:

  • A bullet point list of key code changes that have been made.
  • When describing code changes, try to communicate how and why you implemented something a specific way, not just what has changed.

  • I have assigned myself to this PR and the corresponding issues
  • I have added labels to this PR for the relevant pod(s) affected by these changes
  • I have assigned this PR to the Simorgh project

Testing:

  • Automated (jest and/or cypress) tests added (for new features) or updated (for existing features)
  • If necessary, I have run the local E2E non-smoke tests relevant to my changes (CYPRESS_APP_ENV=local CYPRESS_SMOKE=false npm run test:e2e:interactive)
  • This PR requires manual testing

@tochwill tochwill changed the base branch from latest to integrate-new-navigation December 20, 2019 11:09
@tochwill tochwill marked this pull request as ready for review December 20, 2019 16:29
Copy link
Contributor

@DenisHdz DenisHdz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have run the local e2e non-smoke test for Persian and it passes 👍

e2e-persian

@DenisHdz
Copy link
Contributor

Jenkins is failing as expected #4968 (comment)

@tochwill tochwill merged commit 49f1017 into integrate-new-navigation Jan 2, 2020
@tochwill tochwill deleted the amp-nav-toggle-test branch January 2, 2020 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants