Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Thai timestamps show in Thai #3036

Merged
merged 3 commits into from
Aug 12, 2019
Merged

Make Thai timestamps show in Thai #3036

merged 3 commits into from
Aug 12, 2019

Conversation

Bopchy
Copy link
Contributor

@Bopchy Bopchy commented Aug 9, 2019

Resolves #2965

Overall change: Use moment Thai locale to make Thai timestamps show in Thai.

Code changes:

  • Use moment/locale/th in config/services/thai.
  • Before:

Screenshot 2019-08-09 at 12 02 15

  • After:

Screenshot 2019-08-09 at 12 01 52

  • I have assigned myself to this PR and the corresponding issues
  • Tests added for new features
  • Test engineer approval

@Bopchy Bopchy self-assigned this Aug 9, 2019
@Bopchy Bopchy added this to the Timestamp (WS FP) milestone Aug 9, 2019
EinsteinNjoroge
EinsteinNjoroge approved these changes Aug 9, 2019
View reviewed changes
Copy link
Contributor

@EinsteinNjoroge EinsteinNjoroge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ghost
ghost reviewed Aug 9, 2019
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check chromatic tests.

@david-boydell david-boydell self-assigned this Aug 12, 2019
@david-boydell
Copy link
Contributor

All good. Ready for merge :)

@andrew-nowak
Merge remote-tracking branch 'origin/latest' into 2965-make-timestamp…
2fcff18 
…s-show-in-thai

# Conflicts:
#	src/app/lib/config/services/thai.js
@andrew-nowak andrew-nowak self-assigned this Aug 12, 2019
@andrew-nowak andrew-nowak merged commit 82b171a into latest Aug 12, 2019
@andrew-nowak andrew-nowak deleted the 2965-make-timestamps-show-in-thai branch August 12, 2019 11:06
@kevinlaiGH kevinlaiGH mentioned this pull request Apr 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EinsteinNjoroge EinsteinNjoroge EinsteinNjoroge approved these changes

@dr3 dr3 dr3 approved these changes

Assignees

@andrew-nowak andrew-nowak

@Bopchy Bopchy

@david-boydell david-boydell

Labels
None yet
Projects
None yet
Milestone
Timestamp (WS FP)
Development

Successfully merging this pull request may close these issues.

Make Thai timestamps show in Thai
5 participants
@Bopchy @david-boydell @dr3 @EinsteinNjoroge @andrew-nowak