Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move title and subtitle translations from service config to Ares payload #2947

Merged
merged 12 commits into from
Aug 12, 2019

Conversation

jroebu14
Copy link
Contributor

@jroebu14 jroebu14 commented Aug 7, 2019

Resolves #2810

Overall change: Moves title and subtitle live radio translations for Afaan Oromoo, Amharic, Indonesian, Korean, Tigrinya from service configs to Ares payload.

Code changes:

  • Removes bbc_{service}_radio containing title and subtitle from service configs
  • Adds title and subtitle to content object in the service's liveradio.json
  • Updates the MediaPageMain component to get the title and subtitle from pageData and then render on the page.
  • Rename bbc_afaanoromo_radio/liveradio.json to bbc_afaanoromoo_radio/liveradio.json to fix page 404

Testing notes
Check the following pages still have title and subtitle:

http://localhost.bbc.com:7080/afaanoromoo/bbc_afaanoromoo_radio/liveradio
http://localhost.bbc.com:7080/indonesia/bbc_indonesian_radio/liveradio
http://localhost.bbc.com:7080/korean/bbc_korean_radio/liveradio
http://localhost.bbc.com:7080/amharic/bbc_amharic_radio/liveradio
http://localhost.bbc.com:7080/tigrinya/bbc_tigrinya_radio/liveradio

  • I have assigned myself to this PR and the corresponding issues
  • Tests added for new features
  • Test engineer approval

services affected include Afaan Oromoo, Amharic, Indonesian, Korean, Tigrinya
@jroebu14 jroebu14 requested review from pjlee11 and ryanmccombe August 7, 2019 08:58
@jroebu14 jroebu14 self-assigned this Aug 7, 2019
@jroebu14 jroebu14 requested a review from graeme-lindsay August 7, 2019 09:01
@PriyaKR PriyaKR self-assigned this Aug 12, 2019
@PriyaKR
Copy link
Contributor

PriyaKR commented Aug 12, 2019

LGTM.

@dr3 dr3 merged commit 0033d3b into latest Aug 12, 2019
@dr3 dr3 deleted the move-live-radio-translations branch August 12, 2019 17:44
@jroebu14 jroebu14 mentioned this pull request Aug 13, 2019
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ws-media World Service Media
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move the translations for ContentTitle and SubTitle from the service config to the AReS payload
6 participants