-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move title and subtitle translations from service config to Ares payload #2947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
services affected include Afaan Oromoo, Amharic, Indonesian, Korean, Tigrinya
ryanmccombe
approved these changes
Aug 7, 2019
dr3
approved these changes
Aug 7, 2019
LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2810
Overall change: Moves title and subtitle live radio translations for Afaan Oromoo, Amharic, Indonesian, Korean, Tigrinya from service configs to Ares payload.
Code changes:
bbc_{service}_radio
containingtitle
andsubtitle
from service configscontent
object in the service'sliveradio.json
MediaPageMain
component to get thetitle
andsubtitle
frompageData
and then render on the page.bbc_afaanoromo_radio/liveradio.json
tobbc_afaanoromoo_radio/liveradio.json
to fix page 404Testing notes
Check the following pages still have title and subtitle:
http://localhost.bbc.com:7080/afaanoromoo/bbc_afaanoromoo_radio/liveradio
http://localhost.bbc.com:7080/indonesia/bbc_indonesian_radio/liveradio
http://localhost.bbc.com:7080/korean/bbc_korean_radio/liveradio
http://localhost.bbc.com:7080/amharic/bbc_amharic_radio/liveradio
http://localhost.bbc.com:7080/tigrinya/bbc_tigrinya_radio/liveradio