Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Toggle Navigation ON on Articles #5330

Closed
1 task
sareh opened this issue Jan 30, 2020 · 0 comments · Fixed by #5632
Closed
1 task

Toggle Navigation ON on Articles #5330

sareh opened this issue Jan 30, 2020 · 0 comments · Fixed by #5632
Assignees
@jimjohnsonrollings
Labels
Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test.

Comments

@sareh
Copy link
Contributor

sareh commented Jan 30, 2020 •
edited
Loading

Is your feature request related to a problem? Please describe.

This is blocked on merging in #5234

After releasing the new iteration of the navigation #4571, we should toggle the navigation on on LIVE.

Describe the solution you'd like
Update the toggle value of `navOnArticles https://github.com/bbc/simorgh/blob/latest/src/app/lib/config/toggles/index.js#L72-L74

Describe alternatives you've considered
N/A

Testing notes
[Tester to complete]

Dev insight: Update Cypress tests for nav to remove exception for nav not being on articles

  • This feature is expected to need manual testing.

Additional context
Add any other context or screenshots about the feature request here.
@sareh sareh added blocked This issue should not be worked on until another internal issue is completed - see desc for details Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test. ws-home labels Jan 30, 2020
@jimjohnsonrollings jimjohnsonrollings self-assigned this Feb 21, 2020
@jimjohnsonrollings jimjohnsonrollings mentioned this issue Feb 21, 2020
Merged
6 tasks
@sareh sareh removed the blocked This issue should not be worked on until another internal issue is completed - see desc for details label Feb 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jimjohnsonrollings jimjohnsonrollings

Labels
Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Toggle on Nav for Optimo Articles bbc/simorgh
2 participants
@sareh @jimjohnsonrollings